Skip to content

feat(compiler-vapor): support v-on for component #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 14, 2024
Merged

feat(compiler-vapor): support v-on for component #175

merged 10 commits into from
Apr 14, 2024
+54 −10

Conversation

Doctor-wu
Copy link
Member

related #4

@Doctor-wu
feat(compiler-vapor, runtime-vapor): support listen sub components emit

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
4ecc656 
related vuejs#4
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit 5e76c41
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/661c22db3b44e600096a8882
😎 Deploy Preview https://deploy-preview-175--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 5e76c41
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/661c22db3516160008d99f2d
😎 Deploy Preview https://deploy-preview-175--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Doctor-wu
feat(compiler-vapor): remove unecessary code

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
98bd432
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80 kB 28.1 kB 24.7 kB
compiler-vapor.global.prod.js 49.4 kB (+288 B) 16.8 kB (+82 B) 15.3 kB (+88 B)
runtime-dom.global.prod.js 94.5 kB 35.6 kB 32 kB
runtime-vapor.global.prod.js 42.8 kB 15.9 kB 14.6 kB
vue-vapor.global.prod.js 89.6 kB (+180 B) 31.3 kB (+55 B) 28.3 kB (+11 B)
vue.global.prod.js 152 kB 54.9 kB 49 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.3 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 43.1 kB 15.9 kB 14.6 kB
overall 68.5 kB 26.1 kB 23.6 kB

@Doctor-wu
fix(compiler-core): tweak logic

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
56519b1
@Doctor-wu
feat(compiler-core): tweak expression logic

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
ec03d54
@Doctor-wu
Revert "feat(compiler-core): tweak expression logic"

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
11cc7a1 
This reverts commit ec03d54.
sxzz
sxzz requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unit tests

Doctor-wu and others added 5 commits April 13, 2024 10:33
@Doctor-wu @sxzz
Update packages/compiler-vapor/src/transforms/vOn.ts

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
fece8e6 
Co-authored-by: Kevin Deng 三咲智子 <[email protected]>
@Doctor-wu
Merge branch 'main' into feature-emits

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1a537e8
@Doctor-wu
style(lint): make lint happy

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu
GPG key ID: 7D1412F015912FB2
Verified
Learn about vigilant mode
Loading
Loading status checks…
484b2ff
@sxzz
refactor: toHandlerKey

Verified

This commit was signed with the committer’s verified signature.
sxzz Kevin Deng 三咲智子
SSH Key Fingerprint: I0/gY8Rb7HnU56beA4F5l8qYUOR7E5wLLU6ZF7o6nLQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
460c970
@sxzz
revert runtime

Verified

This commit was signed with the committer’s verified signature.
sxzz Kevin Deng 三咲智子
SSH Key Fingerprint: I0/gY8Rb7HnU56beA4F5l8qYUOR7E5wLLU6ZF7o6nLQ
Verified
Learn about vigilant mode
Loading
Loading status checks…
5e76c41
@sxzz sxzz changed the title feat(compiler-vapor, runtime-vapor): support listen sub components emit feat(compiler-vapor): support listen sub components emit Apr 14, 2024
@sxzz sxzz merged commit a49b6f9 into vuejs:main Apr 14, 2024
8 checks passed
@sxzz sxzz changed the title feat(compiler-vapor): support listen sub components emit feat(compiler-vapor): support v-on for component Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz

Assignees
No one assigned
Labels
compiler enhancement New feature or request runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Doctor-wu @sxzz @LittleSound