fix(theme): skip link jumps to aside instead main content heading/anchor #4940
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge yet, we're going to change a few things to simplify the logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR just search for the first h1 heading with tabindex inside
#VPContent maininstead just inside#VPContent.This PR also adds
position: fixedto the skip link anchor, the skip to content anchor scrolls with the content.The result will be similar to clicking on the first aside link if present without changing the route.Since Skip to Content has an anchor to
#VPContentthere is no way to avoid changing the url.Linked Issues
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.