fix(components):Local navigation location error #4393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
who can help me |
|
111 |
|
I think we should add the Example: vitepress/src/client/theme-default/components/VPContent.vue Lines 86 to 89 in 3cd3aee |
|
@yuyinws ok Thank you for your help. Is that right for me？ |
|
Please fix the CI error. |
|
ok |
|
hello |
|
Please fix the code review. |
|
where |
yuyinws
suggested changes
Feb 13, 2025
| @@ -16,6 +17,7 @@ const open = ref(false) | |||
| const vh = ref(0) | |||
| const main = ref<HTMLDivElement>() | |||
| const items = ref<HTMLDivElement>() | |||
| const {hasSidebar} = useSidebar() | |||
|
|
|||
There was a problem hiding this comment.
add blank space.
Suggested change
| const { hasSidebar } = useSidebar() |
| @@ -165,6 +170,9 @@ function scrollToTop() { | |||
| left: calc(var(--vp-sidebar-width) + 32px); | |||
| width: 320px; | |||
| } | |||
| .VPLocalNavOutlineDropdown:not(.has-sidebar) .items{ | |||
| left:32px; | |||
There was a problem hiding this comment.
add blank space.
Suggested change
| left:32px; | |
| .VPLocalNavOutlineDropdown:not(.has-sidebar) .items { |
|
Sorry my mistake, you can see it now. |
|
is that so? |
|
|
OK！ |
yuyinws
approved these changes
Feb 14, 2025
|
LGTM |
|
hello Did anyone notice this? |
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
c5a8428 to
8abbe29
Compare
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
084cf43 to
d3a1567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4359