Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): handle typescript-language-features module loading race condition #5260

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Mar 7, 2025

fix #5037

In some cases, VSCode will prioritize loading typescript-language-features main script instead of Vue extension main script, so our fs hack code does not work. This PR makes it fault-tolerant.

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5260

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5260

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5260

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5260

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5260

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5260

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5260

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5260

commit: 36de4c2

@johnsoncodehk johnsoncodehk changed the title fix(vscode): handle typescript-language-features module load race condition fix(vscode): handle typescript-language-features module loading race condition Mar 7, 2025
@johnsoncodehk johnsoncodehk merged commit 32c9336 into master Mar 7, 2025
10 checks passed
@johnsoncodehk johnsoncodehk deleted the ext-load-race branch March 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with Language Server when vue file is not open initially
1 participant