feat(component-api-style): add scriptSetupVapor option #2797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: edb5273 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Introduce a new script-setup-vapor option to the Vue component API style rule, allowing <script setup vapor> blocks and enforcing the proper messages when it’s disallowed.
- Extend parser and rule logic to recognize and validate
script-setup-vapor - Add unit tests for both allowing and disallowing
<script setup vapor> - Update documentation with examples and option descriptions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/lib/rules/component-api-style.js | Added tests for the new script-setup-vapor option and errors |
| lib/rules/component-api-style.js | Parsed, flagged, and reported on <script setup vapor> usage |
| docs/rules/component-api-style.md | Documented the script-setup-vapor option with examples |
Comments suppressed due to low confidence (1)
tests/lib/rules/component-api-style.js:124
- Add a test case for
<script setup>(withoutvaporattribute) when bothscript-setupandscript-setup-vaporoptions are enabled to ensure no error is reported.
options: [['script-setup', 'script-setup-vapor']]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #2791
Waiting for the official release of Vue 3.6...