Skip to content

feat: support having all rules in config report at error instead of warn using env variable #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/user-guide/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ You can use the following configs by adding them to `eslint.config.js`.

:::warning Reporting rules
By default, all rules from **base** and **essential** categories report ESLint errors. Other rules - because they're not covering potential bugs in the application - report warnings. What does it mean? By default - nothing, but if you want - you can set up a threshold and break the build after a certain amount of warnings, instead of any. More information [here](https://eslint.org/docs/user-guide/command-line-interface#handling-warnings).

Alternatively, you can set `process.env.VUE_ESLINT_ALWAYS_ERROR` to `true` in your configuration file to have `error` be used by all rules.
:::

#### Specifying Globals (`eslint.config.js`)
Expand Down
1 change: 1 addition & 0 deletions lib/configs/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/

module.exports = {
parserOptions: {
ecmaVersion: 'latest',
Expand Down
1 change: 1 addition & 0 deletions lib/configs/flat/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/

module.exports = [
{
name: 'vue/base/setup',
Expand Down
19 changes: 11 additions & 8 deletions lib/configs/flat/vue2-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,22 @@
'use strict'
const config = require('./vue2-strongly-recommended.js')

const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = [
...config,
{
name: 'vue/vue2-recommended/rules',
rules: {
'vue/attributes-order': 'warn',
'vue/block-order': 'warn',
'vue/no-lone-template': 'warn',
'vue/no-multiple-slot-args': 'warn',
'vue/no-required-prop-with-default': 'warn',
'vue/no-v-html': 'warn',
'vue/order-in-components': 'warn',
'vue/this-in-template': 'warn'
'vue/attributes-order': ruleLevel,
'vue/block-order': ruleLevel,
'vue/no-lone-template': ruleLevel,
'vue/no-multiple-slot-args': ruleLevel,
'vue/no-required-prop-with-default': ruleLevel,
'vue/no-v-html': ruleLevel,
'vue/order-in-components': ruleLevel,
'vue/this-in-template': ruleLevel
}
}
]
49 changes: 26 additions & 23 deletions lib/configs/flat/vue2-strongly-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,34 +6,37 @@
'use strict'
const config = require('./vue2-essential.js')

const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = [
...config,
{
name: 'vue/vue2-strongly-recommended/rules',
rules: {
'vue/attribute-hyphenation': 'warn',
'vue/component-definition-name-casing': 'warn',
'vue/first-attribute-linebreak': 'warn',
'vue/html-closing-bracket-newline': 'warn',
'vue/html-closing-bracket-spacing': 'warn',
'vue/html-end-tags': 'warn',
'vue/html-indent': 'warn',
'vue/html-quotes': 'warn',
'vue/html-self-closing': 'warn',
'vue/max-attributes-per-line': 'warn',
'vue/multiline-html-element-content-newline': 'warn',
'vue/mustache-interpolation-spacing': 'warn',
'vue/no-multi-spaces': 'warn',
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
'vue/no-template-shadow': 'warn',
'vue/one-component-per-file': 'warn',
'vue/prop-name-casing': 'warn',
'vue/require-default-prop': 'warn',
'vue/require-prop-types': 'warn',
'vue/singleline-html-element-content-newline': 'warn',
'vue/v-bind-style': 'warn',
'vue/v-on-style': 'warn',
'vue/v-slot-style': 'warn'
'vue/attribute-hyphenation': ruleLevel,
'vue/component-definition-name-casing': ruleLevel,
'vue/first-attribute-linebreak': ruleLevel,
'vue/html-closing-bracket-newline': ruleLevel,
'vue/html-closing-bracket-spacing': ruleLevel,
'vue/html-end-tags': ruleLevel,
'vue/html-indent': ruleLevel,
'vue/html-quotes': ruleLevel,
'vue/html-self-closing': ruleLevel,
'vue/max-attributes-per-line': ruleLevel,
'vue/multiline-html-element-content-newline': ruleLevel,
'vue/mustache-interpolation-spacing': ruleLevel,
'vue/no-multi-spaces': ruleLevel,
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
'vue/no-template-shadow': ruleLevel,
'vue/one-component-per-file': ruleLevel,
'vue/prop-name-casing': ruleLevel,
'vue/require-default-prop': ruleLevel,
'vue/require-prop-types': ruleLevel,
'vue/singleline-html-element-content-newline': ruleLevel,
'vue/v-bind-style': ruleLevel,
'vue/v-on-style': ruleLevel,
'vue/v-slot-style': ruleLevel
}
}
]
19 changes: 11 additions & 8 deletions lib/configs/flat/vue3-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,22 @@
'use strict'
const config = require('./vue3-strongly-recommended.js')

const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = [
...config,
{
name: 'vue/recommended/rules',
rules: {
'vue/attributes-order': 'warn',
'vue/block-order': 'warn',
'vue/no-lone-template': 'warn',
'vue/no-multiple-slot-args': 'warn',
'vue/no-required-prop-with-default': 'warn',
'vue/no-v-html': 'warn',
'vue/order-in-components': 'warn',
'vue/this-in-template': 'warn'
'vue/attributes-order': ruleLevel,
'vue/block-order': ruleLevel,
'vue/no-lone-template': ruleLevel,
'vue/no-multiple-slot-args': ruleLevel,
'vue/no-required-prop-with-default': ruleLevel,
'vue/no-v-html': ruleLevel,
'vue/order-in-components': ruleLevel,
'vue/this-in-template': ruleLevel
}
}
]
53 changes: 28 additions & 25 deletions lib/configs/flat/vue3-strongly-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,42 +6,45 @@
'use strict'
const config = require('./vue3-essential.js')

const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = [
...config,
{
name: 'vue/strongly-recommended/rules',
rules: {
'vue/attribute-hyphenation': 'warn',
'vue/component-definition-name-casing': 'warn',
'vue/first-attribute-linebreak': 'warn',
'vue/html-closing-bracket-newline': 'warn',
'vue/html-closing-bracket-spacing': 'warn',
'vue/html-end-tags': 'warn',
'vue/html-indent': 'warn',
'vue/html-quotes': 'warn',
'vue/html-self-closing': 'warn',
'vue/max-attributes-per-line': 'warn',
'vue/multiline-html-element-content-newline': 'warn',
'vue/mustache-interpolation-spacing': 'warn',
'vue/no-multi-spaces': 'warn',
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
'vue/no-template-shadow': 'warn',
'vue/one-component-per-file': 'warn',
'vue/prop-name-casing': 'warn',
'vue/require-default-prop': 'warn',
'vue/require-explicit-emits': 'warn',
'vue/require-prop-types': 'warn',
'vue/singleline-html-element-content-newline': 'warn',
'vue/v-bind-style': 'warn',
'vue/attribute-hyphenation': ruleLevel,
'vue/component-definition-name-casing': ruleLevel,
'vue/first-attribute-linebreak': ruleLevel,
'vue/html-closing-bracket-newline': ruleLevel,
'vue/html-closing-bracket-spacing': ruleLevel,
'vue/html-end-tags': ruleLevel,
'vue/html-indent': ruleLevel,
'vue/html-quotes': ruleLevel,
'vue/html-self-closing': ruleLevel,
'vue/max-attributes-per-line': ruleLevel,
'vue/multiline-html-element-content-newline': ruleLevel,
'vue/mustache-interpolation-spacing': ruleLevel,
'vue/no-multi-spaces': ruleLevel,
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
'vue/no-template-shadow': ruleLevel,
'vue/one-component-per-file': ruleLevel,
'vue/prop-name-casing': ruleLevel,
'vue/require-default-prop': ruleLevel,
'vue/require-explicit-emits': ruleLevel,
'vue/require-prop-types': ruleLevel,
'vue/singleline-html-element-content-newline': ruleLevel,
'vue/v-bind-style': ruleLevel,
'vue/v-on-event-hyphenation': [
'warn',
ruleLevel,
'always',
{
autofix: true
}
],
'vue/v-on-style': 'warn',
'vue/v-slot-style': 'warn'
'vue/v-on-style': ruleLevel,
'vue/v-slot-style': ruleLevel
}
}
]
1 change: 1 addition & 0 deletions lib/configs/vue2-essential.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/

module.exports = {
extends: require.resolve('./base'),
rules: {
Expand Down
19 changes: 11 additions & 8 deletions lib/configs/vue2-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,19 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/
const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = {
extends: require.resolve('./vue2-strongly-recommended'),
rules: {
'vue/attributes-order': 'warn',
'vue/block-order': 'warn',
'vue/no-lone-template': 'warn',
'vue/no-multiple-slot-args': 'warn',
'vue/no-required-prop-with-default': 'warn',
'vue/no-v-html': 'warn',
'vue/order-in-components': 'warn',
'vue/this-in-template': 'warn'
'vue/attributes-order': ruleLevel,
'vue/block-order': ruleLevel,
'vue/no-lone-template': ruleLevel,
'vue/no-multiple-slot-args': ruleLevel,
'vue/no-required-prop-with-default': ruleLevel,
'vue/no-v-html': ruleLevel,
'vue/order-in-components': ruleLevel,
'vue/this-in-template': ruleLevel
}
}
49 changes: 26 additions & 23 deletions lib/configs/vue2-strongly-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,34 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/
const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = {
extends: require.resolve('./vue2-essential'),
rules: {
'vue/attribute-hyphenation': 'warn',
'vue/component-definition-name-casing': 'warn',
'vue/first-attribute-linebreak': 'warn',
'vue/html-closing-bracket-newline': 'warn',
'vue/html-closing-bracket-spacing': 'warn',
'vue/html-end-tags': 'warn',
'vue/html-indent': 'warn',
'vue/html-quotes': 'warn',
'vue/html-self-closing': 'warn',
'vue/max-attributes-per-line': 'warn',
'vue/multiline-html-element-content-newline': 'warn',
'vue/mustache-interpolation-spacing': 'warn',
'vue/no-multi-spaces': 'warn',
'vue/no-spaces-around-equal-signs-in-attribute': 'warn',
'vue/no-template-shadow': 'warn',
'vue/one-component-per-file': 'warn',
'vue/prop-name-casing': 'warn',
'vue/require-default-prop': 'warn',
'vue/require-prop-types': 'warn',
'vue/singleline-html-element-content-newline': 'warn',
'vue/v-bind-style': 'warn',
'vue/v-on-style': 'warn',
'vue/v-slot-style': 'warn'
'vue/attribute-hyphenation': ruleLevel,
'vue/component-definition-name-casing': ruleLevel,
'vue/first-attribute-linebreak': ruleLevel,
'vue/html-closing-bracket-newline': ruleLevel,
'vue/html-closing-bracket-spacing': ruleLevel,
'vue/html-end-tags': ruleLevel,
'vue/html-indent': ruleLevel,
'vue/html-quotes': ruleLevel,
'vue/html-self-closing': ruleLevel,
'vue/max-attributes-per-line': ruleLevel,
'vue/multiline-html-element-content-newline': ruleLevel,
'vue/mustache-interpolation-spacing': ruleLevel,
'vue/no-multi-spaces': ruleLevel,
'vue/no-spaces-around-equal-signs-in-attribute': ruleLevel,
'vue/no-template-shadow': ruleLevel,
'vue/one-component-per-file': ruleLevel,
'vue/prop-name-casing': ruleLevel,
'vue/require-default-prop': ruleLevel,
'vue/require-prop-types': ruleLevel,
'vue/singleline-html-element-content-newline': ruleLevel,
'vue/v-bind-style': ruleLevel,
'vue/v-on-style': ruleLevel,
'vue/v-slot-style': ruleLevel
}
}
1 change: 1 addition & 0 deletions lib/configs/vue3-essential.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/

module.exports = {
extends: require.resolve('./base'),
rules: {
Expand Down
19 changes: 11 additions & 8 deletions lib/configs/vue3-recommended.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,19 @@
* This file has been automatically generated,
* in order to update its content execute "npm run update"
*/
const ruleLevel =
process.env.VUE_ESLINT_ALWAYS_ERROR === 'true' ? 'error' : 'warn'

module.exports = {
extends: require.resolve('./vue3-strongly-recommended'),
rules: {
'vue/attributes-order': 'warn',
'vue/block-order': 'warn',
'vue/no-lone-template': 'warn',
'vue/no-multiple-slot-args': 'warn',
'vue/no-required-prop-with-default': 'warn',
'vue/no-v-html': 'warn',
'vue/order-in-components': 'warn',
'vue/this-in-template': 'warn'
'vue/attributes-order': ruleLevel,
'vue/block-order': ruleLevel,
'vue/no-lone-template': ruleLevel,
'vue/no-multiple-slot-args': ruleLevel,
'vue/no-required-prop-with-default': ruleLevel,
'vue/no-v-html': ruleLevel,
'vue/order-in-components': ruleLevel,
'vue/this-in-template': ruleLevel
}
}
Loading