Skip to content

(fixes #230) Fix assignment check in no-side-effects-in-computed-property #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2017
Merged

(fixes #230) Fix assignment check in no-side-effects-in-computed-property #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/rules/no-side-effects-in-computed-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ function create (context) {
return Object.assign({},
{
// this.xxx <=|+=|-=>
'AssignmentExpression > MemberExpression' (node) {
if (utils.parseMemberExpression(node)[0] === 'this') {
'AssignmentExpression' (node) {
if (node.left.type !== 'MemberExpression') return
if (utils.parseMemberExpression(node.left)[0] === 'this') {
forbiddenNodes.push(node)
}
},
Expand Down
19 changes: 19 additions & 0 deletions tests/lib/rules/no-side-effects-in-computed-properties.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
}
})`,
parserOptions
},
{
code: `Vue.component('test', {
computed: {
test () {
let a;
a = this.something
return a
},
}
})`,
parserOptions
}
],
invalid: [
Expand All @@ -128,6 +140,10 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
const test = this.another.something.push('example')
return 'something'
},
test5() {
this.something[index] = thing[index]
return this.something
},
}
})`,
parserOptions,
Expand All @@ -146,6 +162,9 @@ ruleTester.run('no-side-effects-in-computed-properties', rule, {
}, {
line: 17,
message: 'Unexpected side effect in "test4" computed property.'
}, {
line: 21,
message: 'Unexpected side effect in "test5" computed property.'
}]
},
{
Expand Down