Skip to content

fix(runtime-dom): use offsetLeft and offsetTop instead of getBoundingClientRect to avoid transform scale affect animation #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

joo1es
Copy link

@joo1es joo1es commented Jun 14, 2022

Fix #6105
use offsetLeft and offsetTop replace Element.getBoundingClientRect

Copy link

github-actions bot commented Sep 2, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+26 B) 37.7 kB (+6 B) 33.9 kB (-70 B)
vue.global.prod.js 159 kB (+26 B) 57.6 kB (+14 B) 51.2 kB (+63 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 2, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@6108

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@6108

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@6108

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@6108

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@6108

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@6108

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@6108

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@6108

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@6108

vue

pnpm add https://pkg.pr.new/vue@6108

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@6108

commit: 10ded57

@edison1105
Copy link
Member

edison1105 commented Sep 2, 2024

To be sure, the problem was fixed.
re-use test case from #9733

@edison1105 edison1105 added 🔩 p2-edge-case ready for review This PR requires more reviews labels Sep 2, 2024
@edison1105 edison1105 changed the title fix(runtime-dom): avoid transform affect flip animation #6105 fix(runtime-dom): use offsetLeft and offsetTop instead of getBoundingClientRect to avoid transform scale affect animation Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

TransitionGroup Flip will be affected by transform
3 participants