Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): EmitsOptions support named tuple syntax #12676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 9, 2025

close #12673

Copy link

github-actions bot commented Jan 9, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Jan 9, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12676

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12676

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12676

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12676

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12676

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12676

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12676

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12676

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12676

vue

npm i https://pkg.pr.new/vue@12676

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12676

commit: 5d549d2

@edison1105 edison1105 requested a review from jh-leong January 9, 2025 08:04
@jh-leong
Copy link
Member

jh-leong commented Jan 9, 2025

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Jan 9, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt success success
pinia success success
primevue success success
quasar failure success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 marked this pull request as ready for review January 9, 2025 09:10
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type error of defineComponent's second generic param related to EmitsOptions
3 participants