-
Notifications
You must be signed in to change notification settings - Fork 97
EDU-15731 - Delivery Promise FastStore (segunda fase) #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Navigation Preview LinkNo changes detected in the navigation.json file |
Preview LinksOpen this URL to set up the portal with this branch changes. You can now access the edited pages with the following URLs:
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I've commented an issue I've found (we don't have global filter by shipping method) that affects some sections changed in this PR. Another suggestion I'd make is to use screenshots from the faststore's figma instead of SF's, what do you think?
|
||
## Filter options | ||
|
||
With Delivery Promise, shoppers can filter available products by using a [global filter](#global-filter), which affects all navigation, or directly on a [Product List Page (PLP) or search page](#plp-or-search-page-filters), affecting only the current page they're navigating. In both scenarios, they can filter by shipping method or pickup points. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: add something after the ", or" because it was confusing for me -- I thought it was talking about the global filter in the PLP.
Something like: , or by filtering directly on a(...)
or , or a local filter directly on a(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: the last phrase is wrong In both scenarios, they can filter by shipping method or pickup points.
, global filter currently is only to filter by pickup point, and the local filter in PLP is by shipping method (delivery, pickup nearby, pickup at, pickup anywhere)
Grammar review summaryReview for
|
|
||
This solution continuously updates product availability throughout the buying journey by responding to changes in catalog, pricing, inventory, or shipping settings. These updates are then sent to [Checkout](https://developers.vtex.com/docs/guides/checkout-overview) and [Intelligent Search](https://help.vtex.com/tracks/vtex-intelligent-search), ensuring customers see up-to-date options based on their region. | ||
|
||
This feature introduces new hooks as part of the regionalization and location workflow: | ||
## Hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As seções Hooks, Filter options e Default settings são partes mais conceituais da feature ou fazem parte dos passos de configuração?
Fiquei em dúvida porque parece que os passos práticos só aparecem em "Before you begin" e depois. Como essas seções são mais explicativas, vale deixar claro que elas são conceituais ou algo do tipo. Apesar dessas seções serem importantes para contextualizar, não fica claro que são seções concetuais e a pessoa pode esperar passos, mas isso acontece só depois.
Se for o caso dessas três seções acho que vale rever a estrutura do guia. Por exemplo, mudar a estrutura para algo como:
Ter conceitos antes da configuração:
1. Intro
2. Delivery Promise concepts
- Hooks
- Filter options
- Default settings
3. Before you begin
4. Instructions
ou
Ter a configuração /implementação antes e a referência para conceitos depois
1. Intro
2. Before you begin
3. Instructions
4. Delivery Promise concepts
- Hooks
- Filter options
- Default settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
São mais conceituais mesmo. Até pensei em criar uma doc separada pra isso, mas acho que essas informações ficariam meio perdidas sozinhas.
- `useRegion`: Accesses or updates the user's region information, such as postal code or location. | ||
- `useRegionModal`: Handles modal display logic for region selection, especially when the location input is required. | ||
- `useGeoLocation`: Uses the browser’s geolocation API or other client-side methods to attempt to auto-detect the user's location. | ||
This feature introduces the following hooks as part of the regionalization and location workflow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Com esses novos hooks é possível customizar seções ou componentes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pelo o que entendi, não. Vou confirmar.
|
||
You only need to [add a new section](#step-3-adding-region-popover-section), the `Region Popover`. | ||
|
||
### Step 3 - Adding `Region Popover` section | ||
|
||
`RegionPopover` is a section that manages user location inputs. It's used when location data is missing or the store's default postal code is applied. Available in [`@faststore/core`](https://developers.vtex.com/docs/guides/faststore/project-structure-overview#packagejson), `RegionPopover` uses the [`Popover`](https://developers.vtex.com/docs/guides/faststore/molecules-popover) component as its UI base. | ||
`RegionPopover` is a section that manages user location inputs. It's used when location data is missing, or the store's default postal code is applied. Available in [`@faststore/core`](https://developers.vtex.com/docs/guides/faststore/project-structure-overview#packagejson), `RegionPopover` uses the [`Popover`](https://developers.vtex.com/docs/guides/faststore/molecules-popover) component as its UI base. | ||
|
||
 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse código precisa ser implementado em algum lugar? Fiquei com dúvida sobre por que ele aparece aqui, antes dos passos. Vale adicionar uma breve explicação no dropdown explicando sua finalidade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esse código entrou aí porque não teve como documentar esse componente em outro lugar da mesma maneira que documentamos os que estão no faststore/ui. Isso porque o RegionPopover
está somente no core, e não foi possível exportá-lo no vtexdocs/devportal
. A saída, então, foi documentá-lo diretamente na doc do Delivery Promise, inserindo ali também o código.
1. **User-provided location:** If the user provided their location, such as postal code, this information is used. | ||
2. **Logged-in user’s address:** If the user hasn’t provided a postal code, we attempt to identify the location using the logged-in user's address. | ||
3. **Default postal code:** If the user hasn't provided a location, isn’t logged in, or has no saved address, we check if the merchant has configured a default postal code for all buyers. Learn to do so in [Defining a default postal code](#step-4-optional-defining-a-default-postal-code). | ||
1. **Logged in user's address:** If the user is logged in and has a saved address, this information is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O título desse Step 4 com as novas diretrizes que estamos revisando ficará: "Step 4 - (Optional) Defining a default postal code"
Co-authored-by: Mariana Caetano Pereira <[email protected]>
Grammar review summaryReview for
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
Grammar review summaryReview for
|
- `useRegion`: Accesses or updates the user's region information, such as postal code or location. | ||
- `useRegionModal`: Handles modal display logic for region selection, especially when the location input is required. | ||
- `useGeoLocation`: Uses the browser’s geolocation API or other client-side methods to attempt to auto-detect the user's location. | ||
To understand how Delivery Promise operates, see the guide [Delivery Promise (Beta)](https://developers.vtex.com/docs/guides/faststore/features-delivery-promise-overview). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[link-check] reported by reviewdog 🐶
🚨 Found a broken link in a Markdown Link (Error 404):
https://developers.vtex.com/docs/guides/faststore/features-delivery-promise-overview
👉 Please review this link before merging your Pull Request.
Grammar review summaryReview for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [Grammar reviewer] reported by reviewdog 🐶
Added "major version" for clarity and completeness when referring to a version number.
dev-portal-content/docs/faststore/components/features/delivery-promise/implementation.mdx
Line 70 in 85b58b4
<summary>Accounts that want to migrate to the `5.x`</summary> |
Types of changes
EDU-15731