Update node version #1231
Merged
Update node version #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filafb
force-pushed
the
update-node-version
branch
from
30b291a to
a5d7061
Compare
filafb
force-pushed
the
update-node-version
branch
from
a5d7061 to
f7f5b4e
Compare
|
Well written PR, thanks! |
filafb
force-pushed
the
update-node-version
branch
from
0fa2dba to
98c288a
Compare
filafb
force-pushed
the
update-node-version
branch
from
98c288a to
5ecbf7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note to reviewers
The commit 1eb25c3 was added because there were some prettier issues, failing the ci tests.
What is the purpose of this pull request?
Build toolbelt binaries using node current the active LTS version.
What problem is this solving?
Incompatibilities between the toolbelt and its plugins - XTNSNS-665. This issue affects users that get the toolbelt from brew or windows installer (I guess Linux user might face the same issue, but I didn't test it).
How should this be manually tested?
If you want to test it locally, clone the branch and run
yarn release && yarn release:win. The binaries will be available on/lib.I also tested it by linking an application to ensure there wouldn't be any incompatibility with the nodejs version used by the runtime.
Screenshots or example usage
windows
macos
