Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: handle OPTIONS request for CORS #1214

Merged
merged 2 commits into from
Mar 25, 2024
Merged

chore: handle OPTIONS request for CORS #1214

merged 2 commits into from
Mar 25, 2024

Conversation

eduardocesb
Copy link
Contributor

@eduardocesb eduardocesb commented Mar 22, 2024 •
edited
Loading

What is the purpose of this pull request?

  • handle OPTIONS request for CORS

What problem is this solving?

How should this be manually tested?

  • Running toolbelt locally.

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@eduardocesb eduardocesb self-assigned this Mar 22, 2024
@eduardocesb eduardocesb merged commit 7e30602 into main Mar 25, 2024
4 checks passed
@eduardocesb eduardocesb deleted the chore/return-ok-when-method-is-options branch March 25, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvadenisaraujo silvadenisaraujo silvadenisaraujo approved these changes

@filafb filafb filafb approved these changes

Assignees

@eduardocesb eduardocesb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardocesb @silvadenisaraujo @filafb