#trivial Rewrite Spinner component to typescript #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thayannevls
force-pushed
the
chore/spinner-typescript
branch
from
e6dd14c to
e6d83c8
Compare
JuanBarros2
reviewed
Apr 7, 2020
emersonlaurentino
requested changes
Apr 7, 2020
emersonlaurentino
approved these changes
Apr 7, 2020
JuanBarros2
approved these changes
Apr 7, 2020
matheusps
approved these changes
Apr 8, 2020
emersonlaurentino
force-pushed
the
chore/spinner-typescript
branch
from
e055d0a to
813d63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
As the title says.
#1084
How should this be manually tested?
yarn && yarn startScreenshots or example usage
Types of changes