Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 💄 vtex setup #1080

Merged
merged 2 commits into from
Mar 12, 2020
Merged

style: 💄 vtex setup #1080

merged 2 commits into from
Mar 12, 2020

Conversation

emersonlaurentino
Copy link
Member

@emersonlaurentino emersonlaurentino commented Mar 12, 2020

What is the purpose of this pull request?

I added the standard vtex settings that we use for all projects.

This includes eslint and prettier.

I removed the husky and lint-staged part because there are many problems and I would not be able to raise this PR. However, I will open an issue to be added later. (#1081)

What problem is this solving?

code linter and formatter

How should this be manually tested?

run yarn lint locally and see all eslint errors

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

#trivial

Sorry, something went wrong.

@emersonlaurentino emersonlaurentino requested a review from a team March 12, 2020 06:56
@emersonlaurentino emersonlaurentino requested a review from a team as a code owner March 12, 2020 06:56
@emersonlaurentino emersonlaurentino self-assigned this Mar 12, 2020
@emersonlaurentino emersonlaurentino merged commit accfe81 into features Mar 12, 2020
@emersonlaurentino emersonlaurentino deleted the vtex-setup branch March 12, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants