Refactor provider for new Exoscale API v3 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
TheBigLee
force-pushed
the
refactor/v3
branch
6 times, most recently
from
3d6387e to
6204f30
Compare
TheBigLee
requested review from
a team,
Kidswiss,
wejdross and
zugao
and removed request for
a team
TheBigLee
force-pushed
the
refactor/v3
branch
2 times, most recently
from
4dc9f1e to
f180ac1
Compare
TheBigLee
force-pushed
the
refactor/v3
branch
from
f180ac1 to
6ef5253
Compare
Signed-off-by: Nicolas Bigler <[email protected]>
In exoscale v2 we had an interface for the exoscale client, which allowed us to use mockery to create mocks for the tests. Unfortunately v3 doesn't use any interfaces anymore, which makes moking a client much more complicated. We therefore remove those tests for now Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
TheBigLee
force-pushed
the
refactor/v3
branch
from
6ef5253 to
1a96a84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
make test-e2elocally.bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.