Fix/old dependecies and secops #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya, ❤️ This PR intends to update package.json and node js modern evolution of packages and associated ways.
Few key things are update like vsc engine is at
1.101.0and above rather then in old1.31.0or0.32.0Some associated changes are due to dependencies being so old the condition changes could have been done differently like, you might notice check
if proc.stdin is not nullbefore callingend(stdin)to avoid the error, or under K8s sub dir explicitly check theservice type and assign the correct array type to the corresponding property to satisfyTypeScript's type checking, Or check thecallback typeto accept bothNodeJS.ErrnoException and null, matching the Node.jsNoParamCallback signature.Fixed the prepare script:
Before: "prepare": "node ./node_modules/vscode/bin/install && npm run compile"
After: "prepare": "npx @vscode/dts dev && npm run compile",
@vscode/dts dev is the modern replacement for the deprecated vscode/bin/install
Removed the deprecated vscode/bin/install pattern
Successful runs post updates are below. Thanks.
Gentle fyi @squillace ❤️ thanks.