Skip to content

Fix circle-text-body-alignment #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix circle-text-body-alignment #22

wants to merge 1 commit into from

Conversation

AmazingDreams
Copy link

This fixes the circle-text-body-alignment on Firefox at least. Otherwise stuff like this happens:

afbeelding

@skinnyjames skinnyjames self-requested a review May 19, 2019 14:04
@skinnyjames skinnyjames self-assigned this May 19, 2019
skinnyjames
skinnyjames approved these changes May 19, 2019
View reviewed changes
Copy link
Collaborator

@skinnyjames skinnyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I'm not able to reproduce the issue in firefox, but explicitly stating the position of an absolutely positioned element doesn't hurt anything. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skinnyjames skinnyjames skinnyjames approved these changes

Assignees

@skinnyjames skinnyjames

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AmazingDreams @skinnyjames