Add test for invalid task metadata #120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 50.23% 50.23%
=======================================
Files 5 5
Lines 211 211
=======================================
Hits 106 106
Misses 105 105 Continue to review full report at Codecov.
|
I suspect that there is no check for this so it falls back to the regular metadata checks. I'd start with adding all missing fields. |
Sure, I can do that, but do we want metadata-json-lint to also correctly validate task metadata files? Or should that be a separate new feature request? |
|
AFAIK this gem has never done anything with task metadata files. Given all technologies are in here to make it happen, I can see it being in scope for this gem but it would be a new feature request. |
That makes sense. For now, I've changed the test to use a module metadata file which shows the same problem. |
|
This looks like a valid reproducer. Now all we need is someone to write a patch to make the tests pass. |
This is an enhancement of voxpupuli#120 We now use a regex to identify invalid escape sequences. `JSON.parse()` has no built-in way to detect this. Even in strict mode it ignores it: ``` irb(main):002> require 'json' => true irb(main):003> JSON.parser = JSON::Ext::Parser => JSON::Ext::Parser irb(main):004> JSON.parse('{"summary": "A description with an invalid \( escape sequence"}') => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):005> JSON.parse("{\"summary\": \"A description with an invalid \( escape sequence\"}") => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):006> ```
This is an enhancement of voxpupuli#120 We now use a regex to identify invalid escape sequences. `JSON.parse()` has no built-in way to detect this. Even in strict mode it ignores it: ``` irb(main):002> require 'json' => true irb(main):003> JSON.parser = JSON::Ext::Parser => JSON::Ext::Parser irb(main):004> JSON.parse('{"summary": "A description with an invalid \( escape sequence"}') => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):005> JSON.parse("{\"summary\": \"A description with an invalid \( escape sequence\"}") => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):006> ```
This is an enhancement of voxpupuli#120 We now use a regex to identify invalid escape sequences. `JSON.parse()` has no built-in way to detect this. Even in strict mode it ignores it: ``` irb(main):002> require 'json' => true irb(main):003> JSON.parser = JSON::Ext::Parser => JSON::Ext::Parser irb(main):004> JSON.parse('{"summary": "A description with an invalid \( escape sequence"}') => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):005> JSON.parse("{\"summary\": \"A description with an invalid \( escape sequence\"}") => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):006> ```
This is an enhancement of voxpupuli#120 We now use a regex to identify invalid escape sequences. `JSON.parse()` has no built-in way to detect this. Even in strict mode it ignores it: ``` irb(main):002> require 'json' => true irb(main):003> JSON.parser = JSON::Ext::Parser => JSON::Ext::Parser irb(main):004> JSON.parse('{"summary": "A description with an invalid \( escape sequence"}') => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):005> JSON.parse("{\"summary\": \"A description with an invalid \( escape sequence\"}") => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):006> ```
This is an enhancement of voxpupuli#120 We now use a regex to identify invalid escape sequences. `JSON.parse()` has no built-in way to detect this. Even in strict mode it ignores it: ``` irb(main):002> require 'json' => true irb(main):003> JSON.parser = JSON::Ext::Parser => JSON::Ext::Parser irb(main):004> JSON.parse('{"summary": "A description with an invalid \( escape sequence"}') => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):005> JSON.parse("{\"summary\": \"A description with an invalid \( escape sequence\"}") => {"summary"=>"A description with an invalid ( escape sequence"} irb(main):006> ```
2 participants
Add test for task metadata file with invalid escape character.
This test is expected to fail on invalid json, but instead it fails on invalid schema - the task metadata files have a different schema. I'm not sure what exactly happens in
pdk validatewhen no error is raised on this task metadata json.