Skip to content

Fix deprecation warning in btrblocks varbin scheme - #9819

Merged
robert3005 merged 1 commit into
developfrom
rk/fmt
Sep 9, 2026
Merged

Fix deprecation warning in btrblocks varbin scheme#9819
robert3005 merged 1 commit into
developfrom
rk/fmt

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This was a merge conflict

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005
robert3005 requested a review from AdamGS September 9, 2026 17:27
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 9, 2026
@robert3005
robert3005 enabled auto-merge (squash) September 9, 2026 17:27
@codspeed-hq

codspeed-hq Bot commented Sep 9, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 34.56%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 2190 untouched benchmarks
⏩ 218 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 20.4 µs 12.3 µs +66.3%
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.7 µs +21.23%
WallTime arrow_checked_add_u32_avx512[16384] 21.2 µs 17.6 µs +20.84%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/fmt (f9884c4) with develop (2a5b1a7)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
robert3005 merged commit 9d1b103 into develop Sep 9, 2026
134 of 137 checks passed
@robert3005
robert3005 deleted the rk/fmt branch September 9, 2026 17:41
joseph-isaacs pushed a commit that referenced this pull request Sep 9, 2026
…take-neon

Picks up #9819, which fixes the `VarBinBuilder::with_capacity` deprecation
in `vortex-btrblocks` that was failing both `Rust (lint)` jobs on this PR.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants