Reorganize the compressor#8745
Open
connortsui20 wants to merge 1 commit into
Open
Conversation
connortsui20
added
changelog/chore
github-actions
Bot
removed
the
action/benchmark
Member
Author
|
actually I want to move some of the logic out of mod.rs into a cascade.rs file |
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.005x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.005x ➖, 0↑ 0↓)
No file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.967x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.997x ➖, 0↑ 0↓)
datafusion / parquet (0.999x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.997x ➖, 0↑ 1↓)
duckdb / vortex-compact (0.998x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.113x ❌, 0↑ 14↓)
datafusion / vortex-compact (1.020x ➖, 0↑ 0↓)
datafusion / parquet (1.035x ➖, 0↑ 3↓)
datafusion / arrow (1.013x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.095x ➖, 0↑ 12↓)
duckdb / vortex-compact (1.006x ➖, 0↑ 0↓)
duckdb / parquet (1.030x ➖, 0↑ 3↓)
duckdb / duckdb (1.009x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -0.1% overall, 4↑ 6↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.930x ➖, 37↑ 0↓)
datafusion / vortex-compact (0.965x ➖, 17↑ 1↓)
datafusion / parquet (0.967x ➖, 14↑ 2↓)
duckdb / vortex-file-compressed (0.965x ➖, 13↑ 1↓)
duckdb / vortex-compact (0.976x ➖, 9↑ 2↓)
duckdb / parquet (0.978x ➖, 7↑ 2↓)
duckdb / duckdb (0.967x ➖, 15↑ 0↓)
File Size Changes (6 files changed, +0.0% overall, 3↑ 3↓)
Totals:
|
connortsui20
force-pushed
the
ct/compressor-module-refactor
branch
from
751ef7c to
37463ff
Compare
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.941x ➖, 2↑ 1↓)
datafusion / vortex-compact (0.850x ➖, 2↑ 0↓)
datafusion / parquet (0.828x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.984x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.995x ➖, 0↑ 0↓)
duckdb / parquet (0.944x ➖, 0↑ 0↓)
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Merging this PR will improve performance by 10.98%
Performance Changes
Tip Curious why this is faster? Comment Comparing 
Footnotes
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.055x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.017x ➖, 0↑ 0↓)
duckdb / parquet (1.025x ➖, 0↑ 0↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.017x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.993x ➖, 0↑ 0↓)
datafusion / parquet (1.012x ➖, 0↑ 0↓)
datafusion / arrow (1.000x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.007x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.004x ➖, 0↑ 0↓)
duckdb / parquet (1.011x ➖, 0↑ 1↓)
duckdb / duckdb (0.997x ➖, 0↑ 0↓)
File Size Changes (27 files changed, +0.0% overall, 14↑ 13↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.008x ➖, 0↑ 2↓)
datafusion / parquet (1.012x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.006x ➖, 1↑ 0↓)
duckdb / parquet (0.995x ➖, 0↑ 0↓)
duckdb / duckdb (1.002x ➖, 1↑ 0↓)
File Size Changes (101 files changed, -0.0% overall, 52↑ 49↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.909x ➖, 1↑ 2↓)
datafusion / vortex-compact (0.884x ➖, 1↑ 0↓)
datafusion / parquet (0.846x ➖, 3↑ 0↓)
duckdb / vortex-file-compressed (0.907x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.960x ➖, 0↑ 0↓)
duckdb / parquet (0.903x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.902x ➖ How to read Verdict and Engines
unknown / unknown (0.894x ✅, 10↑ 1↓)
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.157x ❌, 0↑ 5↓)
datafusion / parquet (1.000x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.011x ➖, 0↑ 0↓)
duckdb / parquet (1.019x ➖, 0↑ 0↓)
duckdb / duckdb (1.029x ➖, 0↑ 0↓)
File Size Changes (4 files changed, -0.0% overall, 1↑ 3↓)
Totals:
|
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/compressor-module-refactor
branch
from
37463ff to
e87eec5
Compare
Contributor
Benchmarks: CompressionVortex (geomean): 0.997x ➖ How to read Verdict and Engines
unknown / unknown (1.007x ➖, 2↑ 4↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Tracking issue: #7697
I'd like to make some improvements to the compressor logic, and having a better structured file system makes that a bit easier.
This is a purely cosmetic change (except for some paths changing, namely
vortex_compressor::ctx::*andvortex_compressor::estimate::*).What changes are included in this PR?
Moving around a lot of stuff, the tree is now: