Skip to content

Add tsan for vortex-ffi, fix asan instrumentation#7157

Merged
robert3005 merged 1 commit intodevelopfrom
myrrc/sanitizer-ffi
Mar 26, 2026
Merged

Add tsan for vortex-ffi, fix asan instrumentation#7157
robert3005 merged 1 commit intodevelopfrom
myrrc/sanitizer-ffi

Conversation

@myrrc
Copy link
Contributor

@myrrc myrrc commented Mar 25, 2026

  • Add proper instrumentation for vortex-ffi (didn't check memory leaks before due to Mimalloc).
  • Add memory sanitizer and thread sanitizer runtimes for Rust.
  • Remove verbosity=1 from sanitizer output as it's too noisy.
  • Remove VX_DUCKDB_DEBUG since we don't check duckdb code in these jobs.
  • Make address sanitizer fail on error to fail Github action job.
  • Add cross Rust-C address and thread sanitizers.
  • Fix existing sanitizer errors (memory leak in vx_sink).
  • Allow building FFI C part library with Rust's target triple via TARGET_TRIPLE CMake option.

@myrrc myrrc requested a review from AdamGS March 25, 2026 13:57
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 25, 2026

Merging this PR will not alter performance

✅ 1106 untouched benchmarks
⏩ 1522 skipped benchmarks1


Comparing myrrc/sanitizer-ffi (ca2bcbd) with develop (9b1f954)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc force-pushed the myrrc/sanitizer-ffi branch 3 times, most recently from d789597 to b9a88a4 Compare March 25, 2026 15:33
@myrrc myrrc requested review from 0ax1 and removed request for AdamGS March 25, 2026 17:01
@myrrc myrrc force-pushed the myrrc/sanitizer-ffi branch 2 times, most recently from 8e86b62 to 26f8ac6 Compare March 25, 2026 17:27
@myrrc myrrc enabled auto-merge (squash) March 25, 2026 17:28
@myrrc myrrc changed the title sanitizers for CI Add msan,tsan for vortex-ffi, fix asan instrumentation Mar 26, 2026
@myrrc
Copy link
Contributor Author

myrrc commented Mar 26, 2026

@0ax1 notes we should not use Mimalloc by default in vortex-ffi, it should be opt-in.

@myrrc myrrc force-pushed the myrrc/sanitizer-ffi branch from a013bca to d6d0edf Compare March 26, 2026 12:43
@myrrc myrrc requested a review from 0ax1 March 26, 2026 12:55
@myrrc myrrc disabled auto-merge March 26, 2026 12:55
@myrrc myrrc enabled auto-merge (squash) March 26, 2026 12:55
@myrrc myrrc disabled auto-merge March 26, 2026 12:55
@myrrc myrrc enabled auto-merge (squash) March 26, 2026 14:01
@myrrc myrrc force-pushed the myrrc/sanitizer-ffi branch 3 times, most recently from a1d8c1f to d1aff07 Compare March 26, 2026 14:29
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/sanitizer-ffi branch from d1aff07 to ca2bcbd Compare March 26, 2026 14:31
@myrrc myrrc changed the title Add msan,tsan for vortex-ffi, fix asan instrumentation Add tsan for vortex-ffi, fix asan instrumentation Mar 26, 2026
@robert3005 robert3005 disabled auto-merge March 26, 2026 15:16
@robert3005 robert3005 enabled auto-merge (squash) March 26, 2026 15:16
Copy link
Contributor

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have adjusted required checks. Let ship this and make adjustments if necessary

@robert3005 robert3005 merged commit c8eae59 into develop Mar 26, 2026
64 checks passed
@robert3005 robert3005 deleted the myrrc/sanitizer-ffi branch March 26, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants