Add tsan for vortex-ffi, fix asan instrumentation#7157
Merged
robert3005 merged 1 commit intodevelopfrom Mar 26, 2026
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
d789597 to
b9a88a4
Compare
8e86b62 to
26f8ac6
Compare
Contributor
Author
|
@0ax1 notes we should not use Mimalloc by default in vortex-ffi, it should be opt-in. |
0ax1
reviewed
Mar 26, 2026
a013bca to
d6d0edf
Compare
a1d8c1f to
d1aff07
Compare
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
d1aff07 to
ca2bcbd
Compare
robert3005
approved these changes
Mar 26, 2026
Contributor
robert3005
left a comment
There was a problem hiding this comment.
I have adjusted required checks. Let ship this and make adjustments if necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verbosity=1from sanitizer output as it's too noisy.VX_DUCKDB_DEBUGsince we don't check duckdb code in these jobs.TARGET_TRIPLECMake option.