Skip to content

LazyBuffers: use LazyBufferHandle#7092

Draft
gatesn wants to merge 1 commit intongates/lazy-buffers/lazy-bufferfrom
ngates/lazy-buffers/materialize
Draft

LazyBuffers: use LazyBufferHandle#7092
gatesn wants to merge 1 commit intongates/lazy-buffers/lazy-bufferfrom
ngates/lazy-buffers/materialize

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Mar 20, 2026

Summary

Closes: #000

Testing

Signed-off-by: Nicholas Gates <nick@nickgates.com>
Copy link
Contributor Author

gatesn commented Mar 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gatesn gatesn changed the title Add slicing to BufferHandle LazyBuffers: use LazyBufferHandle Mar 20, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1007 untouched benchmarks
⏩ 1529 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%

Comparing ngates/lazy-buffers/materialize (ca88f56) with ngates/lazy-buffers/lazy-buffer (9fd8a54)

Open in CodSpeed

Footnotes

  1. 1529 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant