do not validate already valid arrow varbin arrays#7089
Merged
onursatici merged 1 commit intodevelopfrom Mar 20, 2026
Merged
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
| @@ -275,12 +275,15 @@ where | |||
| DataType::Utf8 | DataType::LargeUtf8 => DType::Utf8(nullable.into()), | |||
| dt => vortex_panic!("Invalid data type for ByteArray: {dt}"), | |||
| }; | |||
Contributor
There was a problem hiding this comment.
at least to a debug assert here
Contributor
Author
There was a problem hiding this comment.
new_unchecked has this under new_unchecked_from_handle:
#[cfg(debug_assertions)]
Self::validate(&offsets, &bytes, &dtype, &validity)
.vortex_expect("[Debug Assertion]: Invalid `VarBinArray` parameters");so we already have dbg assert validate here
joseph-isaacs
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varbin::try_new validates every element of the input array, but for arrow arrays this is already validated, so we can skip validation.
This validation can take longer than compressing and writing the entire array into disk.
on varbinview this is already fixed and we skip validation correctly