Closed
Conversation
AdamGS
added
changelog/feature
Merging this PR will degrade performance by 87.02%
Performance Changes
Comparing 
Footnotes
|
Contributor
|
I think you really want any conversion of vortex arrays to other arrays be an execution |
Contributor
Author
|
WDYM by execution? |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/ext-arrow-exporter
branch
from
f876920 to
88cc0e1
Compare
Contributor
|
Implementation of an Executable trait or something similar so that we can customise it dependeing on the context. For example cuda arrow export is different than host arrow export |
Contributor
Author
|
I think there has to be some mix, you must shift some stuff into the extensions/encodings themselves |
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.984x ➖ datafusion / vortex-file-compressed (0.984x ➖, 3↑ 3↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.996x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.986x ➖, 1↑ 0↓)
datafusion / parquet (0.968x ➖, 3↑ 0↓)
datafusion / arrow (0.992x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.999x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.989x ➖, 0↑ 0↓)
duckdb / parquet (0.973x ➖, 4↑ 2↓)
duckdb / duckdb (0.975x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.990x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.972x ➖, 1↑ 0↓)
datafusion / parquet (0.997x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.007x ➖, 1↑ 1↓)
duckdb / vortex-compact (1.000x ➖, 0↑ 0↓)
duckdb / parquet (1.002x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.018x ➖, 0↑ 4↓)
datafusion / vortex-compact (1.031x ➖, 0↑ 3↓)
datafusion / parquet (1.011x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.060x ➖, 0↑ 22↓)
duckdb / vortex-compact (1.030x ➖, 1↑ 3↓)
duckdb / parquet (1.035x ➖, 0↑ 7↓)
duckdb / duckdb (0.999x ➖, 1↑ 1↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.996x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.976x ➖, 0↑ 0↓)
datafusion / parquet (0.995x ➖, 1↑ 0↓)
datafusion / arrow (0.980x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (0.922x ➖, 5↑ 0↓)
duckdb / vortex-compact (0.958x ➖, 0↑ 0↓)
duckdb / parquet (0.963x ➖, 1↑ 0↓)
duckdb / duckdb (0.971x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (0.960x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.980x ➖, 0↑ 0↓)
duckdb / parquet (0.978x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.891x ➖, 4↑ 0↓)
datafusion / vortex-compact (1.098x ➖, 0↑ 1↓)
datafusion / parquet (0.985x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (0.909x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.935x ➖, 1↑ 0↓)
duckdb / parquet (0.900x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.982x ➖, 5↑ 2↓)
datafusion / parquet (0.967x ➖, 4↑ 0↓)
duckdb / vortex-file-compressed (0.972x ➖, 5↑ 4↓)
duckdb / parquet (0.988x ➖, 1↑ 0↓)
duckdb / duckdb (1.046x ➖, 0↑ 5↓)
Full attributed analysis
|
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
|
The plan was to just have the vortex-arrow crate depend on all the code for the builtin arrow types, not sure there's anything else to change really? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an attempt at playing around with making arrow-exporting both more extendable for Vortex extension types, support arrow's extension types and allow encodings to define their own preferred way to export to arrow (given some inputs).
My main motivation here is wanting to be able to export the upcoming
parquet-variantencoding into a canonical arrow extension type.API Changes
todo!()
Testing
todo!()