Add high-level docs to vortex-btrblocks#6984
Merged
connortsui20 merged 1 commit intodevelopfrom Mar 16, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Comment on lines
+28
to
+31
| //! Each type-specific compressor holds a static list of `Scheme` implementations (e.g. | ||
| //! BitPacking, ALP, Dict). There is no dynamic registry. The compressor evaluates each scheme by | ||
| //! compressing a ~1% sample and measuring the ratio, then picks the best. See `SchemeExt` for | ||
| //! details on how sampling works. |
Contributor
There was a problem hiding this comment.
The type-specific one has encodings switched on or off
Contributor
There was a problem hiding this comment.
But we should likely allow fully dynamic
Contributor
Author
There was a problem hiding this comment.
That is kind of the point of why I was trying to understand this better, I am going to see if we can easily make the compressor pluggable (so that we can compress extension types into custom encodings).
Contributor
There was a problem hiding this comment.
You would need to add schemas to a registry?
Contributor
Author
There was a problem hiding this comment.
Yep, or something potentially more complicated, or a reworking of how we register schemes in the first place
connortsui20
added
changelog/docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decided to add some docs to
vortex-btrblocksas I went through it to try and understand it better.Testing
N/A