runtime: Instrument with tracing#6981
Merged
AdamGS merged 1 commit intovortex-data:developfrom Mar 16, 2026
Merged
Conversation
This is so that tracing subscribers, can correctly attribute information to eg. opentelemetry distributed tracing IDs. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
AdamGS
approved these changes
Mar 16, 2026
Contributor
|
I'm not sure there's a test that will make me super confident that tracing is correctly set up in async rust 😅 code is simple enough and seems correct to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is so that tracing subscribers, can correctly attribute information to eg. opentelemetry distributed tracing IDs.
API Changes
None
Testing
Wrote a test, but didn't check it in because it would require the
stdfeature of tracing and make tracing-subscriber a dependency. Happy to add the test if those things are ok.