Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Merging this PR will improve performance by 18.36%
Performance Changes
Comparing 
Footnotes
|
Comment on lines
+22
to
+28
| let casted_fill = if array.patches().num_patches() == array.len() { | ||
| // When every position is patched the fill scalar is unused and can be undefined. | ||
| // We skip casting it entirely and substitute a default value for the target dtype. | ||
| Scalar::default_value(dtype) | ||
| } else { | ||
| array.fill_scalar().cast(dtype)? | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
just following the order of the constructor, no other reason
Contributor
There was a problem hiding this comment.
okay, also why default vs zero?
Contributor
Author
There was a problem hiding this comment.
if the type is nested it could be expensive (allocations).
Versus just creating a null scalar which is cheap.
joseph-isaacs
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #6979
We should use the default value here to fast path the null, and also the comment was incorrect since casting can always fail.
Testing
N/A