Skip to content

array slots #6870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joseph-isaacs wants to merge 28 commits into
base: develop
Choose a base branch
from
+2,866 −2,348

fix: resolve lint failure and validate variant slots

bd11897
Select commit
Loading
Failed to load commit list.
Draft

array slots #6870

fix: resolve lint failure and validate variant slots
bd11897
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Mar 20, 2026

Performance Regression: -37.75%

⚡ 1 improved benchmark
❌ 38 regressed benchmarks
✅ 977 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation chunked_bool_canonical_into[(1000, 10)] 73.8 µs 82.9 µs -10.99%
❌ Simulation chunked_bool_canonical_into[(100, 100)] 199.9 µs 242.4 µs -17.56%
❌ Simulation chunked_bool_canonical_into[(10, 1000)] 1.7 ms 2.1 ms -19.69%
❌ Simulation chunked_varbinview_canonical_into[(10, 1000)] 3.2 ms 3.6 ms -10.96%
⚡ Simulation chunked_constant_i32_append_to_builder[(1000, 10)] 42.9 µs 32.5 µs +31.85%
❌ Simulation chunked_opt_bool_into_canonical[(1000, 10)] 105 µs 168.7 µs -37.75%
❌ Simulation bench_many_nulls[0.9] 463.1 µs 529.2 µs -12.5%
❌ Simulation bench_many_nulls[0.5] 324.3 µs 361.1 µs -10.2%
❌ Simulation old_alp_prim_test_between[f32, 32768] 398.7 µs 449.1 µs -11.22%
❌ Simulation new_bp_prim_test_between[i32, 32768] 143.6 µs 174.7 µs -17.76%
❌ Simulation new_bp_prim_test_between[i64, 32768] 176.5 µs 237.4 µs -25.67%
❌ Simulation new_bp_prim_test_between[i32, 16384] 95.9 µs 112.8 µs -15.03%
❌ Simulation new_bp_prim_test_between[i16, 32768] 125.6 µs 141.4 µs -11.22%
❌ Simulation new_bp_prim_test_between[i64, 2048] 55.4 µs 62.2 µs -10.98%
❌ Simulation new_bp_prim_test_between[i64, 16384] 112.5 µs 144 µs -21.86%
❌ Simulation old_bp_prim_test_between[i64, 16384] 294.4 µs 329.1 µs -10.54%
❌ Simulation new_alp_prim_test_between[f64, 16384] 124.6 µs 149.9 µs -16.92%
❌ Simulation old_bp_prim_test_between[i64, 32768] 475 µs 540.7 µs -12.13%
❌ Simulation decompress_alp[f32, (1000, 0.01, 0.25)] 13.5 µs 15 µs -10.34%
❌ Simulation decompress_alp[f32, (1000, 0.01, 0.95)] 13.2 µs 15 µs -11.86%
... ... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Comparing ji/slots-for-arrays (bd11897) with develop (2ec79da)2

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (bb45280) during the generation of this report, so 2ec79da was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

View more details on CodSpeed HQ