Fixing OrderBook and Depth streams and adding possibility to specify update speed #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorot93
reviewed
Apr 8, 2020
| "{}", | ||
| match self { | ||
| Self::Default => "", | ||
| Self::Slow => "@1000ms", |
There was a problem hiding this comment.
This seems arbitrary. Are these two values the only accepted ones by Binance? Could you please link their documentation?
There was a problem hiding this comment.
Yes:
https://github.com/binance-exchange/binance-official-api-docs/blob/master/web-socket-streams.md
Should I put that link in the code as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to start a depth stream, but I was getting this error:
Error: invalid length 2, expected struct Bids with 3 elements at line 1 column 112After removing field named "ignore" from model.Asks and model.Bids structs the error dissapears.
Additionally, I added the possibility to set update speed as in binance documentation to one of: 100ms, 1000ms. Please review :)