This repository was archived by the owner on Feb 16, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
2.0.0 #19
Open
thekalinga
wants to merge
8
commits into
voliva:master
Choose a base branch
from
thekalinga:2.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
2.0.0 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thekalinga
commented
Jan 19, 2017
import { InterceptorUtils } from './interceptor-utils'; | ||
import { RealResponseObservableTransformer } from './real-response-observable-transformer'; | ||
|
||
import './object-assign-polyfill'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This import has to be removed from the code. Dint see any errors by tsc. Forgot to remove
…2.0.0, implying angular2, its better to name the artifact aswell with ng2, so that the releases will be future proofed
Once the changes are finalised, we can create a branch The artifact name for that branch can be |
…Direct` which gives access to http API bypassing interception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I done a major refactoring that includes the following new features
http.request(..)
response observable; eg. usecase is OAuth2 flowPlease note that this is not a completed tested code.
Please review the changes & share your views