Change final class
to class
#61
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
php-parser
>5 in my project, BrianHenryIE/strauss.This package looks like it addresses a lot of the work I was about to undertake, thank you.
Unfortunately, due to version differences, I get:
Simple-PHP-Code-Parser/src/voku/SimplePhpParser/Parsers/PhpCodeParser.php
Line 203 in b72daff
If I were able to extend the
PhpCodeParser
class I could maybe address this without forking or relying on a merged PR, but it is afinal
class:Simple-PHP-Code-Parser/src/voku/SimplePhpParser/Parsers/PhpCodeParser.php
Line 26 in b72daff
Proposed Changes
Remove
final
from all classes.