Skip to content

Change final class to class #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrianHenryIE
Copy link

I'm using php-parser >5 in my project, BrianHenryIE/strauss.

This package looks like it addresses a lot of the work I was about to undertake, thank you.

Unfortunately, due to version differences, I get:

Error : Call to undefined method PhpParser\ParserFactory::create()
 /path/to/vendor/voku/simple-php-code-parser/src/voku/SimplePhpParser/Parsers/PhpCodeParser.php:203

$parser = (new ParserFactory())->create(

If I were able to extend the PhpCodeParser class I could maybe address this without forking or relying on a merged PR, but it is a final class:

Proposed Changes

Remove final from all classes.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant