fix(fspy): replace the IPC file lock with an in-mapping close gate

[wan9chi]

Motivation

The current quiescence protocol attaches "may write" to a shared mapping but "is still writing" to a file-lock descriptor. A descendant that closes descriptors it does not recognize releases the lock while it keeps write access to the mapping, so the receiver can read frames while a straggler mutates them. The #544 investigation pinned this as the root cause.

This PR replaces the lock with a gate stored in the shared memory itself, where a writer cannot lose it while it can still write. One atomic word admits and counts each claim. The runner closes with one fetch_or at root-process exit, which fences all future claims and reports whether a write was still in flight. A zero count proves every claim ran to completion: the memory is frozen, and the runner reads and caches. A nonzero count means the run is not cached. In-flight windows last microseconds and the runner closes milliseconds after wait returns, so a nonzero count is rare. The closed bit and the count share one word on purpose; with two atomics, a writer could check the flag before the close and publish its count after it, which is the file lock's race in new clothes.

The close drops the shared memory's keeper, so the attach window ends with the close: a process that starts later fails at open, and a sender that attached earlier has its claims refused. On Linux, the seccomp supervisor's stop also returns without waiting: each listener task hands over what it recorded and a detached task keeps answering notifications, so a live filtered process keeps working while its later accesses go unrecorded. Draining those listeners to EOF used to mean waiting for every filtered descendant to exit, which reintroduced the daemon hang this PR removes.

A process may also call exit while another of its threads is mid-send, which would abandon a gate guard and mark the whole run incomplete. The preload now interposes exit and _exit and waits the few microseconds until in-flight sends finish before the process dies. Signals and crashes still skip this, and the runner handles those by not caching the run. Windows parity is a follow-up.

Semantics change: fspy no longer waits for lingering descendants after the root process exits, and it does not track accesses made after that exit. Collecting the trace no longer delays vp run; a task that leaks a daemon no longer blocks the read step. This fixes #396, where the receiver's exclusive flock waited on shared flocks inherited by Playwright/Chromium's setsid tree. Stdio pipe draining can still hold a run open and is tracked separately in #485.

Closes #544
Closes #396

🤖 Generated with Claude Code

[wan9chi]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• refactor(fspy): simplify shm_io to a plain frame arena #578
• fix(fspy): replace the IPC file lock with an in-mapping close gate #577 👈 (View in Graphite)
• fix(ipc): use named FIFOs for task communication on Unix #569
• fix(fspy): unify shared memory on a sparse temp file across all platforms #576
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

fspy benchmark

linux

dynamic/launch             change +153.33%  [+130.44% .. +171.77%]  overhead  +280.11%
dynamic/access             change  +8.42%  [ +7.16% ..  +9.30%]  overhead   +67.00%
static/launch              change +193.86%  [+164.14% .. +221.79%]  overhead  +661.39%
static/access              change  -0.14%  [ -1.72% ..  +1.21%]  overhead  +818.13%

macos

dynamic/launch             change  -0.69%  [ -4.49% ..  +4.55%]  overhead  +224.77%
dynamic/access             change  +7.35%  [ -4.18% .. +13.03%]  overhead   +23.03%

windows

dynamic/launch             change  -0.89%  [ -4.59% ..  +4.34%]  overhead   +28.05%
dynamic/access             change  +1.58%  [ +0.18% ..  +2.64%]  overhead   +10.13%

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb42117817

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".