Skip to content

dependsOn object form cannot reach a task behind a package that lacks it; the query can #738

Description

@jasonkuhrt

Problem

{ task, from } selects direct dependencies only, and the docs say recursion comes from each dependency task declaring its own entry. That chain breaks at any package that does not define the task, and every task must have a command, so a source-only package cannot relay.

app ──> ui (no generate) ──> icons (has generate)

app#build: dependsOn: [{ task: 'generate', from: 'dependencies' }]

vp run app#build on a clean checkout never runs icons#generate. vp run -t app#generate does, because the query bridges ui (skip-intermediate reconnection, task-query.md). The two mechanisms disagree about the same package graph.

Why it matters

In a monorepo whose packages are consumed as source, the only per-package preparation is code generation, and only some packages have it (25 of 121 for us). Every consumer task (test, lint, build) needs "generate in everything I transitively depend on". That is a cross-name dependency, so the query cannot express it (-t test would run test everywhere), and nested vp run -t generate is not deduplicated (#323). Today we name far-away producers by hand in a consumer that does not depend on them, keep a hand-written list of every producer for the workspace type build, and run vp run -r generate as a CI pre-pass.

Ask (either)

  1. { task: 'generate', from: 'dependencies', transitive: true }: materialize edges to the task across transitive dependencies through from, bridging packages that lack it, which is the skip-intermediate reconnection the query already implements. task-query.md argues against stored topological edges because package selection is per query; an explicit entry does not vary per query, so that argument does not apply.
  2. Allow a task with dependsOn and no command, so a source-only package can relay. This is Turborepo's documented Transit Nodes pattern (a task that "doesn't do anything because it doesn't match a script in any package.json"). Without it we need command: 'true' in about 100 packages.

Option 1 is the better end state: no relay tasks at all.

Versions: vite-plus 0.3.3; read against vite-task b11dbb9 (UserDependsOnEntry::Package is documented "Direct package dependency selection entry").

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions