Conversation
Reuse existing catalog selections and fill missing managed entries before installation. Preserve user-defined versions and unrelated workspace configuration.
Contributor
Author
|
I found that using |
SaKaNa-Y
marked this pull request as ready for review
September 26, 2026 06:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Please take a moment to read this. Thank you!
I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).
If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.
I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)
I hold myself to this standard for every PR, regardless of its size.
When I run
vp create vite:applicationin an existing pnpm workspace without the required catalog entries, dependency installation fails withERR_PNPM_CATALOG_ENTRY_NOT_FOUND_FOR_SPEC. The create flow writescatalog:references forviteandvite-plusinto the new application'spackage.jsonbut leaves their version definitions missing frompnpm-workspace.yaml. The generated application should have resolvable dependencies so installation can complete.This change reuses the workspace's catalog selection when rewriting the new application, then adds its missing Vite+-managed catalog entries before installation. It supports default and named catalogs, preserves explicit catalog references and existing versions, and limits updates to the entries needed by the new application.
Verification
just snapshot-test create_existing_pnpm_workspacepreviously passed: it checks catalog output and lockfile creation, then runs a frozen installation and application build. Before the fix, it failed because installation produced no lockfile.