fix(install): verify modern Yarn hashes against the CLI binary#2227
Draft
leslieeilsel wants to merge 1 commit into
Draft
fix(install): verify modern Yarn hashes against the CLI binary#2227leslieeilsel wants to merge 1 commit into
leslieeilsel wants to merge 1 commit into
Conversation
Added verification for Yarn binary hash for modern Yarn installations. Updated download logic to handle Yarn 2+ package manager correctly. Signed-off-by: Leslie Lau <1178273431@qq.com>
✅ Deploy Preview for viteplus-preview canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packageManagerhashes against the extractedbin/yarn.js, matching CorepackWhy
Corepack writes Yarn 2+ integrity pins from the extracted CLI binary, while Vite+ previously compared them with the npm tarball hash. This made valid Corepack pins fail with a cold Vite+ cache and appear to pass with a warm cache because the cached artifact was not re-verified.
Fixes #2209
Test Plan
cargo fmt --all -- --checkcargo test -p vite_install --lockedcargo check -p vite_install --all-features --all-targets --lockedcargo clippy -p vite_install --all-targets --all-features --locked -- --deny warningsvp installrejects a Corepack-writtenpackageManagerpin: vp hashes the .tgz, Corepack hashes the extracted binary #2209 with cold and warm cachesyarn.jsreturnsHashMismatchwithout downloading again