This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
DRAFT: Chore/bump to 2024 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wisskirchenj thanks for the PR! We are in process of upgrading the associated on-demand, instructor-led courses and certification to Spring Boot 3.3/Spring 6.1. As part of the upgrade, the assets for the new courses will be in different repos. I'll leave the PR open for now such that the course author can review. Thanks again! |
|
@billkable thanks for your quick reply! In that case, I will not pursue this PR unless you tell me otherwise :-) No big deal - I just spent one hour max. so far... That is exactly, why I asked in advance :-) Best, Jürgen |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I started the Spring Academy course Spring Core today, I was astonished, that the code base of the course is ~3yrs old and on Spring 2.7 & Java 11 still...
This PR bumps the 2022 dependencies into the presence, i.e.
The necessary migrations (javax -> jakarta, meanwhile renamed dependencies) as well as replacing immutable classes by Java records and most of the IDE-/Sonar fixes are only performed for the first 4 modules (00, 01 and 10 10-solution) yet.
That is why the PR is marked draft - and can't be merged yet - the other modules won't compile.
But before continuing this work, please let me know, if there is interest, to go ahead in that way and renovate the remaining modules too.
Please let me know - in that case, I will focus on doing the necessary migrations for other modules, to successfully run and test the code soon to make this draft PR ready to merge.
PS: I made sure, that the academy course videos do not contradict the renovated code - e.g. I added the getter methods for Dining-record, because they are used in the video demonstration...