Support possible German umlauts in email address strings #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In German language, and of course in many others, there are special characters, i.e. the so-called umlauts in case of German.
Under some circumstances these characters are supported by modern SMTP servers, see i.e. this discussion. (this is also an interesting related read)
We are also experiencing this within our data, but unfortunately
rinkus auto_link mechanics fail to handle email addresses for mailto-links correctly, if the email address contains an umlaut.Current behavior
Expected behavior
Discussion
Our PR is restricted only on the case of German umlauts, but of course we see that a wider range of characters are affected for other languages, i.e.
ñor cases likeé. We were not 100% certain how to proceed for this and would be happy for some advice. Is the approach we've taken in the code, namely extending the lookup for special characters, the right one here?Maybe we're on the wrong track and the support for those characters should get added to rinkus
rinku_isalnum()function. What do you think?