Skip to content

Conversation

@yewentao256
Copy link
Member

@yewentao256 yewentao256 commented Oct 20, 2025

Purpose

Batch Invariant for R1 TP 8 on Blackwell

Backend: FlashinferMLA

Test

VLLM_ATTENTION_BACKEND=FLASHINFER_MLA VLLM_TEST_TP_SIZE=8 VLLM_TEST_MODEL="deepseek-ai/DeepSeek-R1" pytest -s -v tests/v1/generation/test_batch_invariance.py -k test_logprobs_bitwise_batch_invariance_bs1_vs_bsN[FLASHINFER]

PASSED

== 1 passed, 6 deselected, 4 warnings in 120.24s (0:02:00) ===

Signed-off-by: yewentao256 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables batch invariance for the FLASHINFER_MLA attention backend by adding it to the list of supported backends. The change is correct and aligns with the goal of supporting more backends for deterministic, batch-invariant execution. I've added one high-severity comment suggesting a refactor of the hardcoded list of supported backends. While the current change is fine, moving to a more dynamic approach where backends declare their own capabilities would improve maintainability and prevent this list from becoming a source of silent errors in the future.

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 20, 2025
@vllm-bot vllm-bot merged commit 86ed770 into main Oct 21, 2025
47 of 49 checks passed
@vllm-bot vllm-bot deleted the wentao-batch-invariant-for-deepseekr1-tp branch October 21, 2025 17:25
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Oct 21, 2025
sstamenk pushed a commit to sstamenk/vllm that referenced this pull request Oct 23, 2025
usberkeley pushed a commit to usberkeley/vllm that referenced this pull request Oct 23, 2025
@yewentao256 yewentao256 self-assigned this Oct 23, 2025
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

Development

Successfully merging this pull request may close these issues.

3 participants