-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Docs] Update Tensorizer usage documentation #21190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Docs] Update Tensorizer usage documentation #21190
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR provides a much-needed update to the tensorizer
documentation, reflecting recent simplifications to its usage within vLLM. The new documentation is clearer and more comprehensive. I've identified one paragraph that could be misleading regarding the configuration of serialization versus deserialization and have suggested a clarification to improve user understanding.
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Sanger Steel <[email protected]>
Signed-off-by: William Goldby <[email protected]> Signed-off-by: Sanger Steel <[email protected]>
Signed-off-by: William Goldby <[email protected]> Signed-off-by: Sanger Steel <[email protected]>
Signed-off-by: Sanger Steel <[email protected]>
Signed-off-by: Sanger Steel <[email protected]>
96cb1df
to
c1ba86c
Compare
Signed-off-by: Sanger Steel <[email protected]>
Anything else needed to get this merged? @simon-mo @hmellor @jeejeelee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some review comments that I accidentally left pending
Signed-off-by: Sanger Steel <[email protected]>
@hmellor Resolved comments! Thanks for the suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for improving the Tensorizer doc!
(adding force-merge
because the PR is docs only)
Updated
tensorizer
usage patterns documentationThis PR updates the two
tensorizer
usage information sources on vLLM: the example script, and its dedicated documentation page. It reflects the new usage patterns made by recenttensorizer
feature updates, and provides a more detailed guide on usingtensorizer
with vLLM.