Skip to content

Conversation

sidhpurwala-huzaifa
Copy link
Member

@sidhpurwala-huzaifa sidhpurwala-huzaifa commented Jul 17, 2025

Working on a new updated security policy for the project.

Most of the things were unsaid, like issue triage and security sevs, so documented them. Also added an initial version of a pre-notification policy.

@mergify mergify bot added the documentation Improvements or additions to documentation label Jul 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly expands the project's security policy, adding important details on issue triage, severity levels, and a pre-notification process. The changes improve clarity for both users and contributors on how security issues are handled. My review focuses on ensuring the language in this formal document is clear, correct, and professional. I've pointed out a few grammatical and spelling issues that should be addressed to maintain the document's quality.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 requested a review from russellb July 17, 2025 12:57
@russellb
Copy link
Member

minor thing - can you add Signed-off-by to your commit messages? That's required to make the DCO bot happy.

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this is great. I support the addition of the prenotification policy, allowing trusted parties that ship vllm to participate in a coordinated release. My suggestions are fairly minor, I think.

sidhpurwala-huzaifa and others added 12 commits July 22, 2025 16:35
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Accept language change suggestions from gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Accept language change suggestions from gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Accept language change suggestions from gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Accept language change suggestions from gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Accept language change suggestions from gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>

Co-authored-by: Russell Bryant <[email protected]>
@russellb
Copy link
Member

One last suggestion - how about a link from https://docs.vllm.ai/en/latest/contributing/vulnerability_management.html back to SECURITY.md? You can find it in the docs/ directory

@sidhpurwala-huzaifa
Copy link
Member Author

One last suggestion - how about a link from https://docs.vllm.ai/en/latest/contributing/vulnerability_management.html back to SECURITY.md? You can find it in the docs/ directory

Hmm, i can see already the following line in the vuln management page:
"As mentioned in the security policy, security vulnerabilities may be reported privately to the project via GitHub."

Also, it seems like there may be a need to "consolidate" the vuln disclosure section of the page a bit, inline with the pre-notification policy. How about we commit the security policy first and then review how this page can be changed to be in sync with the policy?

@russellb
Copy link
Member

One last suggestion - how about a link from https://docs.vllm.ai/en/latest/contributing/vulnerability_management.html back to SECURITY.md? You can find it in the docs/ directory

Hmm, i can see already the following line in the vuln management page: "As mentioned in the security policy, security vulnerabilities may be reported privately to the project via GitHub."

Also, it seems like there may be a need to "consolidate" the vuln disclosure section of the page a bit, inline with the pre-notification policy. How about we commit the security policy first and then review how this page can be changed to be in sync with the policy?

sounds good. I missed the link, sorry.

Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @simon-mo should review, as well.

Thanks!

@sidhpurwala-huzaifa
Copy link
Member Author

@simon-mo hey, could you look at this MR and see if it makes sense to you?

@simon-mo simon-mo merged commit d666466 into vllm-project:main Aug 1, 2025
14 checks passed
wenscarl pushed a commit to wenscarl/vllm that referenced this pull request Aug 4, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: shuw <[email protected]>
juuice-lee pushed a commit to juuice-lee/vllm-moe.code that referenced this pull request Aug 5, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: x22x22 <[email protected]>
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: x22x22 <[email protected]>
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
jingyu-ml pushed a commit to jingyu-ml/vllm that referenced this pull request Aug 8, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: jingyu <[email protected]>
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Jinzhen Lin <[email protected]>
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Noam Gat <[email protected]>
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
googlercolin pushed a commit to googlercolin/vllm that referenced this pull request Aug 29, 2025
Signed-off-by: Huzaifa Sidhpurwala <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Russell Bryant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants