Skip to content

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Jul 16, 2025

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jul 16, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request upgrades the schemathesis dependency to version 4.0.9 in the nightly_torch_test.txt, test.in, and test.txt files. No specific issues were identified that meet the criteria for 'high' or 'critical' severity.

Copy link

mergify bot commented Jul 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @davidxia.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 17, 2025
@Stranger6667
Copy link

Just want to note that there could be some false positives in positive_data_acceptance and negative_data_rejection checks. I plan to solve them completely in 4.1 (scheduled for release this / next week)

@mergify mergify bot removed the needs-rebase label Aug 19, 2025
@davidxia davidxia changed the title [CI] upgrade schemathesis to 4.0.9 [CI] upgrade schemathesis to 4.1.0 from 3.39.15 Aug 22, 2025
@davidxia davidxia marked this pull request as ready for review August 22, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants