Skip to content

[WIP] Voxtral tests #20999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[WIP] Voxtral tests #20999

wants to merge 11 commits into from

Conversation

patrickvonplaten
Copy link
Collaborator

Follow up of: #20970

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables a previously skipped test for Mistral-based models. However, the removed code included a TODO comment specifying that the test should only be enabled after a release. Merging this change prematurely could introduce instability. I have added a critical comment recommending that the test remains skipped until the condition from the TODO is met.

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Jul 15, 2025
patrickvonplaten and others added 9 commits July 15, 2025 21:04
@patrickvonplaten @DarkLight1337
Voxtral (vllm-project#20970)
25e3022 
Signed-off-by: Patrick von Platen <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Patrick von Platen <[email protected]>
@DarkLight1337 @patrickvonplaten
[CI/Build] Fix wrong path in Transformers Nightly Models Test (vllm-p…
1379948 
…roject#20994)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Patrick von Platen <[email protected]>
@hmellor @patrickvonplaten
[Deprecation] Remove everything scheduled for removal in v0.10.0 (vll…
83a2c86 
…m-project#20979)

Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Patrick von Platen <[email protected]>
@hmellor @patrickvonplaten
Configure Gemini (vllm-project#20971)
858c8d6 
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Patrick von Platen <[email protected]>
@patrickvonplaten
WIP
5343ce0 
Signed-off-by: Patrick von Platen <[email protected]>
@patrickvonplaten
WIP
b4bb70c 
Signed-off-by: Patrick von Platen <[email protected]>
@patrickvonplaten
WIP
5844882 
Signed-off-by: Patrick von Platen <[email protected]>
@patrickvonplaten
WIP
c5c0ec8 
Signed-off-by: Patrick von Platen <[email protected]>
@patrickvonplaten
WIP
3fa8369 
Signed-off-by: Patrick von Platen <[email protected]>
@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend new-model Requests to new models labels Jul 15, 2025
@mergify mergify bot added the tool-calling label Jul 15, 2025
@mergify Mergify
Copy link

mergify bot commented Jul 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @patrickvonplaten.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jul 15, 2025
@mergify mergify bot removed the needs-rebase label Jul 15, 2025
@patrickvonplaten
up
f8dda61 
Signed-off-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@hmellor hmellor Awaiting requested review from hmellor

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@youkaichao youkaichao Awaiting requested review from youkaichao

@mgoin mgoin Awaiting requested review from mgoin

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth

@houseroad houseroad Awaiting requested review from houseroad

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ci/build documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) new-model Requests to new models tool-calling
Projects
Tool Calling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickvonplaten @DarkLight1337 @hmellor