-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
[Frontend] OpenAI Responses API supports input image #20975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: chaunceyjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chaunceyjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for image inputs within the OpenAI Responses API, allowing users to send images via URLs or base64 encoding. This enhancement expands the API's multimodal capabilities, enabling it to process visual information alongside text.
Highlights
- OpenAI Responses API Image Support: The API now accepts image inputs through a new
input_image
type, aligning with OpenAI's vision capabilities for multimodal models. - Flexible Image Input Handling: Images can be provided either as direct URLs or as base64 encoded strings, offering versatility for different use cases.
- Robust Parsing Logic: New parsing mechanisms have been implemented in
chat_utils.py
to correctly interpret and process theResponseInputImageParam
type for multimodal content. - Comprehensive Test Coverage: A new test suite has been added to validate the functionality for single and multiple image inputs, including adherence to configured image limits per prompt.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for image inputs to the OpenAI-compatible responses
API. The changes in vllm/entrypoints/chat_utils.py
correctly introduce a new parser for input_image
and integrate it into the existing multi-modal content parsing logic. A new test file is added to verify the functionality with single and multiple images, both as URLs and base64 encoded data. I've found a critical issue in one of the new tests where an incorrect parameter name is used, which prevents the test from validating the intended success path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: chaunceyjiang <[email protected]>
Signed-off-by: chaunceyjiang <[email protected]>
Head branch was pushed to by a user without write access
The tests are failing, PTAL |
Signed-off-by: chaunceyjiang <[email protected]>
Head branch was pushed to by a user without write access
From the logs, it appears that vllm encountered an OOM (Out of Memory) error. Could you help retry the e2e test? |
Signed-off-by: chaunceyjiang <[email protected]>
0cf2d8e
to
236546a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the tests
) Signed-off-by: chaunceyjiang <[email protected]> Signed-off-by: Himanshu Jaju <[email protected]>
) Signed-off-by: chaunceyjiang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Follow up #20504
https://platform.openai.com/docs/guides/images-vision?api-mode=responses
OpenAI Responses API supports input image
Test Plan
Added test cases.