-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
add support for qwen3 moe model EPLB #20967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @hsliuustc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Qwen3 Mixture of Experts (MoE) model by integrating Expert Parallel Load Balancing (EPLB) capabilities. The primary goal is to improve LLM serving throughput by enabling dynamic management of expert assignments and supporting redundant experts, thereby optimizing resource utilization and balancing computational load across devices in an expert-parallel environment.
Highlights
- EPLB Integration: This pull request introduces support for Expert Parallel Load Balancing (EPLB) within the Qwen3 Mixture of Experts (MoE) model. This is achieved by adding
enable_eplb
andnum_redundant_experts
parameters to the model's configuration and propagating them through theQwen3MoeSparseMoeBlock
andQwen3MoeDecoderLayer
down to theFusedMoE
layers. - MixtureOfExperts Protocol Implementation: The
Qwen3MoeForCausalLM
class now implements theMixtureOfExperts
interface. This involves collecting allFusedMoE
layers within the model and exposing MoE-specific properties such asnum_logical_experts
,num_physical_experts
, andnum_redundant_experts
. - Dynamic Expert Load Balancing: A new
set_eplb_state
method has been added toQwen3MoeForCausalLM
. This method allows for dynamic updates to the expert load view, logical-to-physical expert mapping, and logical replica counts, which are crucial for real-time load balancing across experts in an expert-parallel setup. - Refactored Weight Loading: The
load_weights
mechanism for the Qwen3 MoE model has been updated to correctly handle the mapping and loading of weights for redundant experts, ensuring that the model can properly initialize with the new EPLB configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for EPLB for the Qwen3 MoE model. I found a critical bug in the type checking for MoE layers and a fragile piece of logic for identifying an example layer. My review provides suggestions to fix these issues to ensure the feature works correctly and robustly.
example_layer = typing.cast( | ||
Qwen3MoeSparseMoeBlock, | ||
self.model.layers[config.num_hidden_layers - 1].mlp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current logic for getting example_layer
assumes the last layer of the model is always a MoE layer. This is fragile and might fail if config.num_hidden_layers
is not a multiple of config.decoder_sparse_step
.
example_layer = next(layer.mlp for layer in self.model.layers
if isinstance(layer.mlp, Qwen3MoeSparseMoeBlock))
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
This pull request add support for qwen3 moe model EPLB feature, which helps to improve the overall thoughput during LLM Serving.
#20468
Test Plan
Test Result
will add the test result later
(Optional) Documentation Update