-
-
Notifications
You must be signed in to change notification settings - Fork 9k
Add Dockerfile argument for VLLM_USE_PRECOMPILED environment #20943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dockerfile argument for VLLM_USE_PRECOMPILED environment #20943
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dougbtv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the Docker build process by adding a configurable argument to control the use of pre-compiled vLLM wheels. This provides greater flexibility for build environments, particularly for CI/CD pipelines, by allowing for potential optimizations in build times.
Highlights
- Dockerfile Build Argument: I've introduced a new Docker build argument,
VLLM_USE_PRECOMPILED
, which defaults to0
. This argument allows users to specify whether pre-compiled vLLM wheels should be used during the Docker image build process. - Environment Variable Propagation: The value of the
VLLM_USE_PRECOMPILED
build argument is now also set as an environment variable within the Docker image. This ensures that the setting is available for subsequent build steps and potentially at runtime within the container. - CI Optimization Potential: The primary intent behind this change is to enable conditional wheel building in CI pipelines. By leveraging this argument, CI runs can potentially save time by skipping the compilation of vLLM wheels when pre-compiled versions are suitable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new build argument VLLM_USE_PRECOMPILED
to the Dockerfile, which allows for conditionally using pre-compiled wheels. This is a useful addition for optimizing CI build times. The implementation in the Dockerfile is correct. My only suggestion is to remove a leftover test comment from the README.md
file.
de2656c
to
716e07a
Compare
see also: vllm-project/ci-infra#125 |
716e07a
to
a191307
Compare
e0c2142
to
3597ded
Compare
Specifically for use in CI testing, so we can expose this at build time. Adds to main Dockerfile, as well as Dockerfile.rocm Signed-off-by: dougbtv <[email protected]>
3597ded
to
caea6f8
Compare
…oject#20943) Signed-off-by: dougbtv <[email protected]> Signed-off-by: Himanshu Jaju <[email protected]>
…oject#20943) Signed-off-by: dougbtv <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
This adds a build argument so that we can determine if we want to set VLLM_USE_PRECOMPILED in order to conditionally build the wheel during CI testing. Which could potentially save time during runs when the wheel doesn't need to be built.
Test Plan
Should have no impact without implementation and uses a current default. Can be manually tested with:
Test Result
(exit 0)
(Optional) Documentation Update