Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Support Mistral3 in V1 #15950

Merged

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Apr 2, 2025

VLLM_USE_V1=1 python examples/offline_inference/vision_language.py -m mistral3
...
The image depicts a picturesque scene featuring the iconic Tokyo Skytree, a tall broadcasting and observation tower located in Tokyo, Japan. The tower is framed by a canopy of cherry blossom (sakura) trees in full bloom. The blossoms are predominantly pink, creating a vibrant contrast against the clear blue sky.

Copy link

github-actions bot commented Apr 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin marked this pull request as ready for review April 2, 2025 15:23
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update docs as well?

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this locally as well, so otherwise LGTM

Signed-off-by: mgoin <[email protected]>
@mergify mergify bot added the documentation Improvements or additions to documentation label Apr 2, 2025
@vllm-bot vllm-bot merged commit f021b97 into vllm-project:main Apr 2, 2025
6 of 8 checks passed
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants