-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Hacks for the ROCm port #1314
Conversation
@pcmoritz I'd like to submit a pull request to replace the usage of HIP API for type conversions for Float16 with ASM volatile instructions. Additionally, I've modified the setup.py file to check for the availability of ROCMHOME, and if it is set, the flags are updated to include -DUSE_ROCM. Would appreciate it if you could review the pull request and let me know if there are any issues or concerns. Thanks! |
This is getting tests working on top of #1313
Currently the following tests are working:
kernels/test_activation.py
kernels/test_cache.py
kernels/test_layernorm.py
kernels/test_pos_encoding.py
Currently, the following test is failing:
kernels/test_attention.py
with