-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1][Metrics] Add GPU prefix cache hit rate % gauge #12592
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
2bdfb1e
to
a768360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cody!
c5196d9
to
4c85956
Compare
After the second thought. I feel it might be easier to simply maintain the cache hit rate of the most recent N (e.g., 1k) requests. This aligns the logging flow better because we take a snapchat of the scheduler stat in every step. It also makes more sense to me because the cache hit rate doesn't associate with time but only requests. WDYT? |
Gentle ping @markmc |
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
4c85956
to
e2aa6de
Compare
Part of #10582
cc @markmc @robertgshaw2-redhat