Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Metrics] Add GPU prefix cache hit rate % gauge #12592

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Jan 30, 2025

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 30, 2025
Copy link
Contributor

@markmc markmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cody!

vllm/v1/core/kv_cache_manager.py Outdated Show resolved Hide resolved
vllm/v1/metrics/loggers.py Show resolved Hide resolved
vllm/v1/core/scheduler.py Outdated Show resolved Hide resolved
@comaniac
Copy link
Collaborator Author

After the second thought. I feel it might be easier to simply maintain the cache hit rate of the most recent N (e.g., 1k) requests. This aligns the logging flow better because we take a snapchat of the scheduler stat in every step. It also makes more sense to me because the cache hit rate doesn't associate with time but only requests. WDYT?

@mergify mergify bot added the v1 label Feb 1, 2025
@comaniac
Copy link
Collaborator Author

comaniac commented Feb 4, 2025

Gentle ping @markmc

Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Signed-off-by: Cody Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants