Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] add arg pad_for_invariant_seq_len #12397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Jan 24, 2025

We need arg pad_for_invariant_seq_len in Ascend NPU backend because variable length input is not supported in FA op of torch-npu yet. Thus this pr ensures the accuracy of the inference on npu.

pad_for_invariant_seq_len is disabled by default, so that it won't influence any other backends.

ps. We'll revert it when the variable length input is supported, if this is not nessary for any other backend

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@MengqingCao MengqingCao force-pushed the fix branch 2 times, most recently from 62852a5 to b2aa8dd Compare January 24, 2025 09:47
@MengqingCao
Copy link
Contributor Author

@DarkLight1337 could you help review this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant