[V1] APC + prompt logprobs unsupported (PR 2/N for v1 sample and prompt logprobs support) #11910
+1,786
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#10763) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
…0805) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
…oject#10804) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Chen Zhang <[email protected]> Co-authored-by: Isotr0py <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…t#10502) This PR provides initial support for single-node disaggregated prefill in 1P1D scenario. Signed-off-by: KuntaiDu <[email protected]> Co-authored-by: ApostaC <[email protected]> Co-authored-by: YaoJiayi <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
vllm-project#10809) Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
…ect#10799) Signed-off-by: Max de Bayser <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: xffxff <[email protected]> Signed-off-by: Isotr0py <[email protected]> Co-authored-by: Isotr0py <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Co-authored-by: Woosuk Kwon <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…roject#10825) Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…hecks Signed-off-by: Andrew Feldman <[email protected]>
afeldman-nm
requested review from
WoosukKwon,
robertgshaw2-redhat,
njhill,
ywang96,
comaniac and
alexm-redhat
as code owners
Signed-off-by: Andrew Feldman <[email protected]>
…gprobs, and cumulative_logprob to RequestOutput Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…g abstraction Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
…dy passing) Signed-off-by: Andrew Feldman <[email protected]>
…nizer tests pass Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Signed-off-by: Andrew Feldman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces the v1
LLMEngineandAsyncLLMto fail ingenerate()if a request with prompt logprobs enabled arrives and the engine has prefix caching enabled. Note that while it is possible for prompt logprobs and APC to be compatible, this is left to future work.This is part of a broader vllm v1 + logprobs workstream:
PR no. 1 (#9880 ) is a dependency of this PR; it adds the infrastructure for sample and prompt logprobs support with limited unit tests
PR no. 2 is this PR
PR no. 3 will port test_completion.py logprobs tests to v1, make any adjustments required to make these tests pass, and fix a compatibility issue with Mistral tokenizer